Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(FooterCfGov): allows className and other standard footer props to pass to the inner Footer #333

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented Apr 2, 2024

closes #332

Allows for custom styling which is needed in cfpb/sbl-frontend#369

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit f9d962f
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/660f0737ba44900008fa5114
😎 Deploy Preview https://deploy-preview-333--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@billhimmelsbach
Copy link
Contributor

Heyo! I don't think we need this now do we @shindigira?

@shindigira
Copy link
Contributor Author

shindigira commented Apr 3, 2024

Heyo! I don't think we need this now do we @shindigira?

Not for the footer white space fix, but for future proofing Necessary. Won't need a wrapper div for the fix in cfpb/sbl-frontend#369.

@shindigira shindigira merged commit 02a69c4 into main Apr 4, 2024
7 of 9 checks passed
@shindigira shindigira deleted the footerCfGov-className branch April 4, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FooterCfGov] Allow custom classname
3 participants